semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Python: Adding core HttpSkill

Open JTremb opened this issue 2 years ago • 2 comments

Motivation and Context

HttpSkill python version

Description

  • Porting the HttpSkill from C# to Python.
  • Adding corresponding unit tests.

Contribution Checklist

  • [x] The code builds clean without any errors or warnings
  • [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
  • [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
  • [x] All unit tests pass, and I have added new tests where possible
  • [x] I didn't break anyone :smile:

JTremb avatar Apr 18 '23 12:04 JTremb

@awharrison-28 Thanks! updated.

btw there's the same linting error than my other PR with those files :

would reformat /home/runner/work/semantic-kernel/semantic-kernel/python/semantic_kernel/kernel.py
would reformat /home/runner/work/semantic-kernel/semantic-kernel/python/tests/end-to-end/basics.py
would reformat /home/runner/work/semantic-kernel/semantic-kernel/python/tests/unit/orchestration/test_context_variables.py

I can fix this in one of them.

JTremb avatar Apr 21 '23 00:04 JTremb

Please fix the double empty lines and whitespace changes that don't contribute to the functionality of the code.

Consider a dedicated PR for whitespace changes that improve code readability.

MovGP0 avatar Apr 21 '23 14:04 MovGP0