Joshua Hiltbrand

Results 7 comments of Joshua Hiltbrand

Dear @perrotta , I have squashed to one commit, and also refined a little logic after reviewing some test failures.

Hi @perrotta , Thank you for the logic simplification suggests. I agree about having things more simple for easier debugging. @Michael-Krohn and I agree that your suggestions should not change...

Looking at some of the weirdly failed tests, I realize that a parameter called `theThreshold` (used in legacy PFA2 TP emulation) had been mistakenly changed to be `theVetoThreshold`---they are wholly...

> Hi @JHiltbrand -- out of curiosity why with this PR would we see [less TPs in the HCAL Barrel](https://cms-docs.web.cern.ch/hcal-sw-validation/calo_scan_single_pi/15_1_X/15_1_X_PR48311_Run4D110_1000fb_vs_15_1_0_pre2_Run4D110_1000fb_SinglePi/N_TP_HB.gif)? (If I am reading that plot correctly) Hi @BenjaminRS ,...

Hi @RobertJWard , Thanks for the validation results and explanation; I think this makes sense. For the dotted line, that would be where the "legacy" $

Hi @aloeliger , Thanks for making the PR, I will test this in the local workflow I have and report back

Hi @aloeliger , I pulled your PR into my working area for 14_1_0, and reran my step3. I now find the number of processed HCAL TPs in the HcalDigis validation...