cmssw Add Veto Threshold to HCAL TP Emulator

PR description:

This PR incorporates a threshold for vetoing when applying the FIR filter during emulation of HCAL TP energy reconstruction in HB and HE. The veto threshold is taken from the auxi2 field of the HcalTPChannelParameters object for robust control of the veto threshold online and offline.

Small change in logic is incurred at L519 of HcalTrigPrimAlgo, where check_sat is now only defined by saturation in BX0 or BX1.

N.B.: The veto thresholds have yet to be uploaded to the conditions database. So, the overrideDBvetoThreshold is set to True thereby keeping the veto disabled for now. A simple PR to flip the switch can be performed.

ATTN: @Michael-Krohn, @abdoulline, @jhakala

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is targeting 14_1_X; however, a backport shall be prepared for 14_0_X.

Mar 11 '24 22:03 JHiltbrand

cms-bot internal usage

Mar 11 '24 22:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39421

This PR adds an extra 60KB to repository

Mar 11 '24 22:03 cmsbuild

A new Pull Request was created by @JHiltbrand for master.

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos (alca, l1)
CaloOnlineTools/HcalOnlineDb (db)
SimCalorimetry/HcalTrigPrimAlgos (l1)
SimCalorimetry/HcalTrigPrimProducers (l1)

@perrotta, @francescobrivio, @cmsbuild, @aloeliger, @saumyaphor4252, @consuegs, @epalencia can you please review it and eventually sign? Thanks. @bsunanda, @yuanchao, @sameasy, @mmusich, @rovere, @missirol, @rsreds, @PonIlya, @abdoulline, @tocheng this is something you requested to watch as well. @antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Mar 11 '24 22:03 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39432

This PR adds an extra 56KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39432/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39432/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

Mar 12 '24 12:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39435

This PR adds an extra 56KB to repository

Mar 12 '24 13:03 cmsbuild

Pull request #44373 was updated. @aloeliger, @saumyaphor4252, @perrotta, @consuegs, @francescobrivio, @cmsbuild, @epalencia can you please check and sign again.

Mar 12 '24 13:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39441

This PR adds an extra 100KB to repository

Mar 12 '24 17:03 cmsbuild

Pull request #44373 was updated. @francescobrivio, @saumyaphor4252, @perrotta, @cmsbuild, @epalencia, @consuegs, @aloeliger can you please check and sign again.

Mar 12 '24 17:03 cmsbuild

please test

Mar 13 '24 07:03 perrotta

-1

Failed Tests: RelVals RelVals-INPUT AddOn Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a03f1/38089/summary.html COMMIT: a9f968027c83ce0ee41120fcde420789730a64e2 CMSSW: CMSSW_14_1_X_2024-03-12-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44373/38089/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

5.15.1_TTbarFS/step1_TTbarFS.log
135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
136.731136.731_RunSinglePh2016B/step2_RunSinglePh2016B.log

Expand to see more relval errors ...

RelVals-INPUT

4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
6.06.0_SingleMuPt1/step2_SingleMuPt1.log

Expand to see more relval errors ...

AddOn Tests

fastsim

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 6 sec (ended on Wed Mar 13 09:03:12 2024) - exit: 256

fastsim1

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 2 sec (ended on Wed Mar 13 09:03:13 2024) - exit: 256

fastsim2

[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 2 sec (ended on Wed Mar 13 09:03:15 2024) - exit: 256

Expand to see more addon errors ...

Mar 13 '24 08:03 cmsbuild

Moreover, a squash into just one or two commits should be done before submitting the updates with the fix (otherwise it will be requested anyhow before the final integration)

Mar 13 '24 09:03 perrotta

Dear @perrotta , I have squashed to one commit, and also refined a little logic after reviewing some test failures.

Mar 13 '24 14:03 JHiltbrand

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39454

This PR adds an extra 48KB to repository

Mar 13 '24 14:03 cmsbuild

Pull request #44373 was updated. @saumyaphor4252, @epalencia, @cmsbuild, @consuegs, @francescobrivio, @aloeliger, @perrotta can you please check and sign again.

Mar 13 '24 14:03 cmsbuild

Hi @perrotta , Thank you for the logic simplification suggests. I agree about having things more simple for easier debugging. @Michael-Krohn and I agree that your suggestions should not change anything. I have added these changes in.

Mar 14 '24 20:03 JHiltbrand

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39482

This PR adds an extra 32KB to repository

Mar 14 '24 20:03 cmsbuild

Pull request #44373 was updated. @consuegs, @cmsbuild, @francescobrivio, @epalencia, @aloeliger, @saumyaphor4252, @perrotta can you please check and sign again.

Mar 14 '24 20:03 cmsbuild

please test

Mar 14 '24 22:03 perrotta

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a03f1/38145/summary.html COMMIT: cf2c5016f81fe93aa50dce95e0a27fe09ae56d1f CMSSW: CMSSW_14_1_X_2024-03-14-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44373/38145/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 102 lines to the logs
Reco comparison results: 77 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297383
DQMHistoTests: Total failures: 1849
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3295514
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: found differences in 3 / 46 workflows

Mar 15 '24 01:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39499

This PR adds an extra 52KB to repository

Mar 15 '24 15:03 cmsbuild

Pull request #44373 was updated. @aloeliger, @perrotta, @consuegs, @epalencia, @cmsbuild, @saumyaphor4252, @francescobrivio can you please check and sign again.

Mar 15 '24 15:03 cmsbuild

please test

Mar 15 '24 21:03 perrotta

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a03f1/38181/summary.html COMMIT: 14fdc6604e391bb60ef3757f99564b63d60b65f6 CMSSW: CMSSW_14_1_X_2024-03-15-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44373/38181/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 13 lines from the logs
Reco comparison results: 51 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297383
DQMHistoTests: Total failures: 497
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3296866
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: found differences in 3 / 46 workflows

Mar 16 '24 00:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39531

This PR adds an extra 52KB to repository

Mar 18 '24 22:03 cmsbuild

Pull request #44373 was updated. @perrotta, @epalencia, @aloeliger, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio can you please check and sign again.

Mar 18 '24 22:03 cmsbuild

Looking at some of the weirdly failed tests, I realize that a parameter called theThreshold (used in legacy PFA2 TP emulation) had been mistakenly changed to be theVetoThreshold---they are wholly different. The former seems deprecated in my view, but I focus on the changes for the prefire veto. Likewise, I have made some changes to logic based on additional discussion with @Michael-Krohn and online ops.

Mar 18 '24 22:03 JHiltbrand

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39535

This PR adds an extra 36KB to repository

Mar 19 '24 00:03 cmsbuild

Pull request #44373 was updated. @cmsbuild, @epalencia, @aloeliger, @perrotta, @consuegs, @saumyaphor4252, @francescobrivio can you please check and sign again.

Mar 19 '24 00:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39536

This PR adds an extra 52KB to repository

Mar 19 '24 01:03 cmsbuild

Pull request #44373 was updated. @epalencia, @aloeliger, @saumyaphor4252, @perrotta, @consuegs, @cmsbuild, @francescobrivio can you please check and sign again.

Mar 19 '24 01:03 cmsbuild