Jeff Dutil

Results 112 comments of Jeff Dutil

You should probably have them return the same currency objects for consistency.

@pavelnikolov was this the solution to #106 for you?

I believe this is actually a separate issue than #106 which should be all set now. Is it normal that there could be a negative tax amount w/VAT? That seems...

Sorry I'm not familiar enough with how the VAT works. I wouldn't think you would have a negative amount when checking out. I could understand if there was a refund...

Could you please provide a pull request fixing this behavior with a regression test. The second line of the get_taxonomies method should probably be ||= not = as that will...

Oh yea that's what I get for not taking my time reading that.

No your understanding is correct on how it should work, but as you've mentioned it is not going to work properly if get_taxonomies is not the method called to find...

ActiveShipping has smart post: https://github.com/Shopify/active_shipping/blob/master/lib/active_shipping/carriers/fedex.rb#L51 A calculator needs to be added to this extension to take advantage of it I believe.