Jeff Dutil

Results 112 comments of Jeff Dutil

The changes look okay to me, but I haven't manually tested things out.

@jasonfb if your up for it a PR against the store credits branch would be nice https://github.com/spree/spree/pull/5917

Yea targeted on master branch to be included whenever it's finished. I'm pretty sure it just needs the views, and to make sure specs are passing I could be wrong...

I don't believe this would cause any issues. Would you be able to submit a PR with specs covering the issue?

@christoph-buente I have an extension spree_contact_us that it is apparently wanting to integrate with. http://github.com/jdutil/spree_contact_us

If you write regression tests for the behavior I think that would be nice to add.

This theme is no longer maintained I would not recommend using it.

Yea you can't use uniq with postgres instead you need to use a DISTINCT clause like: https://github.com/spree/spree/blob/master/core/app/helpers/spree/taxons_helper.rb#L7

Could you submit a pull request?

I don't use or care about paypal at all. The specs fail terribly on this extension for me as well so I'm not going to be touching anything here until...