Hrafn Malmquist

Results 21 comments of Hrafn Malmquist

I agree. I am generating SVGs on the fly using python and that would be a super useful feature.

I have the same issue using a Postgres cache.

I am a new django-ratelimit user, thanks for a great package. I think it is both counter-intuitive ***and*** not clear at all from the documentation that the default behaviour when...

As this change has a +1 and eyeballing the code it looks quite sane I am leaning towards merging when checks are done. Same with #2296 @kshepherd, any comments?

@mwoodiupui : thanks. Using the setParameterList method instead of setParameter seems to do the trick. At least no error is generated. But I haven't done any actual testing. I am...

I've tested the current commit: 314a844 by submitting a four items and placing one of them in a restricted collection. `curl -v -X POST --data "[email protected]&password=testing" http://localhost:8080/rest/login` use cookie id...

@terrywbrady thanks for taking this on My understanding is that the filtered-items endpoint uses the itemService findByMetadataQuery method https://github.com/DSpace/DSpace/blob/d75d97e2a65f047f75f4d62f9bdf70a5ad9918b7/dspace-rest/src/main/java/org/dspace/rest/FilteredItemsResource.java#L132 which in turn uses the itemDAO findByMetadataQuery method https://github.com/DSpace/DSpace/blob/d75d97e2a65f047f75f4d62f9bdf70a5ad9918b7/dspace-api/src/main/java/org/dspace/content/ItemServiceImpl.java#L1037 Unlike other...

I should note that equivalent changes can be made to the bitstreams endpoint before a merge is made.

Okay, so that's +3. What do you think @kshepherd ?

@tdonohue , I will try to answer the issues you've raised the best I can. It's been almost three years since the PR was made and I must stress that...