django-ratelimit icon indicating copy to clipboard operation
django-ratelimit copied to clipboard

Adjust the examples to have actual side-effects

Open jensenbox opened this issue 4 years ago • 2 comments

Most of the examples did not any effect on the request when they should have been rate limited. This was initially deceptive as it was not clear that nothing would happen. These changes show the ways in which you can have a rate limit actually happen.

I would propose that the default behavior would have the block option set to True but I would not do that without a larger version number change.

jensenbox avatar May 10 '21 23:05 jensenbox

Actually, https://github.com/jsocol/django-ratelimit/discussions/229 has been open without objection for a while, maybe it's time to just make that change, a long with publishing a v4 that actually uses the django_ratelimit package name.

jsocol avatar Aug 29 '21 16:08 jsocol

I am a new django-ratelimit user, thanks for a great package.

I think it is both counter-intuitive and not clear at all from the documentation that the default behaviour when the rate is exceeded is for nothing to happen.

I would support making this more explicitly visible in document and examples.

J4bbi avatar Sep 06 '22 12:09 J4bbi

Appreciate the push here, as of #269 / 4.0, this is the default. This PR definitely helped make the call to change it!

jsocol avatar Apr 16 '23 17:04 jsocol