Isira Seneviratne

Results 67 comments of Isira Seneviratne

Thanks for the feedback, I'll look into the issues you mentioned. Update: I was able to reproduce the first issue. I'm running Android 12 on my main device, so maybe...

I removed the video player UI toggle method, should be okay now.

> > > Also the video player is broken, fullscreen button won’t fullscreen until you play/pause, then if you exit fullscreen it will do wtf and touch video controls still...

> Sorry, I took a small break over the past week to relax after the past semester. > > Could this be rebased to remove the dev merge commit? Sure.

When checking the change in `PicassoHelper` on my Galaxy Tab A6 (Android 8.1), I found that the result bitmap was mutable while the source was immutable, so I removed the...

> Could you provide screenshots for comparison? Does the benefits exceed the cost of possibly having bugs or crashes? ![Screenshot_20220804-193704.jpg](https://user-images.githubusercontent.com/31027858/182868001-a823cbbf-0a27-473b-bd54-4a2862c243c2.jpg) The documentation mentions that a mutable bitmap is returned if...

@Stypox I added a mutable copy operation if the resulting bitmap was immutable (this only happens if the source bitmap was returned and it was immutable). @mhmdanas Can you update...

> I agree with @TacoTheDank, it makes little sense to me to show a notification if there is _no_ update available, plus it would be quite irritating. What problem are...

@TobiGr Yeah, I'll make that change.

> I get the following error, probably the wrong thread or context are used? > > ``` > java.lang.NullPointerException: Can't toast on a thread that has not called Looper.prepare() >...