Isira Seneviratne
Isira Seneviratne
> @Isira-Seneviratne How have you been able to merge this without an approving review? If I remember correctly, it was approved by @TobiGr .
> > to backport Linkify improvements > > Idle curiosity. What are these improvements? I checked the code, and it backports the implementations of the `Linkify` methods on Android 9.0...
Also, Retrofit [requires](https://github.com/square/retrofit/blob/master/CHANGELOG.md#version-270-2019-12-09) at least API level 21, as it relies on OkHttp. Will that be a deal-breaker for this particular proposed change?
> > Also, Retrofit [requires](https://github.com/square/retrofit/blob/master/CHANGELOG.md#version-270-2019-12-09) at least API level 21, as it relies on OkHttp. Will that be a deal-breaker for this particular proposed change? > > Not since the...
> > NewPipe now requires API level 21. > > Does the extractor also require API level 21 too? At the moment it requires API level 19 (due to using...
> I don't think so, as some apps use the extractor on lower APIs, such as SkyTube. Oh, right. In that case, changes will need to be made as `StandardCharsets`...
> It seems like the player crashes (though without a notification) when entering or leaving fullscreen. Thanks for the feedback, will look into this.
I undid the view model changes in this PR, I'll make them in a separate one.
> Now there is a similar change to do in FeedGroupCarouselItem This line? ``` max(1, viewBinding.recyclerView.width / DeviceUtils.dpToPx(112, context)) ``` It doesn't seem like there's anything that needs to be...
> Opening any video crashes the app. The `PendingIntent` mutability flags [are required when targeting Android 12 and higher](https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability), and most of the `PendingIntent`s created in the app don't have...