Use ListAdapter for search predictions.

[Isira-Seneviratne]

What is it?

• [ ] Bugfix (user facing)
• [x] Feature (user facing)
• [x] Codebase improvement (dev facing)
• [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

• Use ListAdapter to handle displaying list data in PeertubeInstanceListFragment, SuggestionListAdapter and PreferenceSearchAdapter.

Before/After Screenshots/Screen Record

• Before:
  • Video search: https://user-images.githubusercontent.com/31027858/182021881-f60beea1-e880-42f8-a9d2-173b8ea8f72d.mp4
  • Preference search: https://user-images.githubusercontent.com/31027858/182053004-86985d79-852b-4dfd-a3f0-1df1b83c7c4b.mp4
• After:
  • Video search: https://user-images.githubusercontent.com/31027858/182021890-30818b27-d39d-43d5-91d0-8d041227225a.mp4
  • Preference search: https://user-images.githubusercontent.com/31027858/182053021-971da415-3bb9-491e-a986-b297d48bbc91.mp4

Fixes the following issue(s)

• Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• [x] I read the contribution guidelines.

[TacoTheDank]

Sorry, I took a small break over the past week to relax after the past semester.

Could this be rebased to remove the dev merge commit?

[Isira-Seneviratne]

Sorry, I took a small break over the past week to relax after the past semester.

Could this be rebased to remove the dev merge commit?

Sure.

[TacoTheDank]

@Stypox Are we doing a feature freeze until v0.24.0 is released, or can this be merged now?

[Stypox]

No, we have not decided upon a freeze, you can proceed @TacoTheDank

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

[TacoTheDank]

Thanks for this feature!