NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Refactor VideoDetailFragment.

Open Isira-Seneviratne opened this issue 2 years ago • 6 comments

What is it?

  • [ ] Bugfix (user facing)
  • [ ] Feature (user facing)
  • [x] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use lambdas for view listeners in VideoDetailFragment.

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Isira-Seneviratne avatar Aug 21 '22 03:08 Isira-Seneviratne

It seems like the player crashes (though without a notification) when entering or leaving fullscreen.

tsiflimagas avatar Nov 02 '22 23:11 tsiflimagas

It seems like the player crashes (though without a notification) when entering or leaving fullscreen.

Thanks for the feedback, will look into this.

Isira-Seneviratne avatar Nov 03 '22 03:11 Isira-Seneviratne

I undid the view model changes in this PR, I'll make them in a separate one.

Isira-Seneviratne avatar Nov 03 '22 14:11 Isira-Seneviratne

It seems to be working fine in general now.

tsiflimagas avatar Nov 03 '22 23:11 tsiflimagas