Victor Krylov

Results 8 comments of Victor Krylov

Is there any interest in fixing this? I can give it a try but I need to know where to start looking.

> @widal001, thank you for the detailed issue report; there is a proposed solution on #477; we will release a 3.0 Safety version with improved capabilities and a fix for...

I saw this https://github.com/aws/aws-for-fluent-bit/blob/604204ecb9efdb06440cfea08d2c3e83adefc983/troubleshooting/debugging.md?plain=1#L1737-L1748 Looks like cloudwatch_logs is defined here https://github.com/fluent/fluent-bit/tree/master/plugins/out_cloudwatch_logs but does not support `new_log_group_tags` yet. This is the only issue I see referencing this parity gap https://github.com/fluent/fluent-bit/issues/7376.

I've bisected this issue, it doesn't occur in gcr.io/ml-pipeline/frontend:2.0.0-beta.0 but it does occur in gcr.io/ml-pipeline/frontend:2.0.0-beta.1. I think the issue is somewhere in the https://github.com/kubeflow/pipelines/blob/2.0.0-beta.1/frontend/src/pages/RunDetailsV2.tsx code, will continue to dig. Also...

Would appreciate help from @jlyaoyuli on changes in https://github.com/kubeflow/pipelines/commit/ca2004ca6c35759bc2a1b8d47e7e77431166b2f7. My current intuition is that the hasFinishedV2() call is getting triggered on the onFocus event but is validating incorrectly causing a...

OK I narrowed the issue down to [commit for RunDetailsRouter.tsx](https://github.com/kubeflow/pipelines/commit/ab2499dd272654112bea9a3df31238ed6e05fd50#diff-37f9c9259b6880838ea23979ae30d2439f9adfb832740a3c66fcea26ded13216R73-R76), specifically commenting out the following lines fixes it: ```tsx if (runIsFetching || templateStrIsFetching) { return Currently loading recurring run information;...

@changhyuni what's the blocker on fluentbit supporting the TagLogGroup API?

It should be possible to extend the CreateLogGroup call to include tags right, https://github.com/fluent/fluent-bit/blob/master/plugins/out_cloudwatch_logs/cloudwatch_api.c#L1297-L1329, https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_CreateLogGroup.html. That code would probably need to be changed a little to use JSON encoder instead...