fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

Does cloudwatch plugin support LogGroup tag?

Open changhyuni opened this issue 1 year ago • 6 comments

Is your feature request related to a problem? Please describe. Dose cloudwatch plugin support LogGroup tag?

Describe the solution you'd like I want to manage tags for cloud watch LogGroups in fluentbit

Additional context It seemed to be supported in the old before version(go) https://github.com/aws/amazon-cloudwatch-logs-for-fluent-bit/blob/mainline/cloudwatch/cloudwatch.go#L140

changhyuni avatar Jun 05 '24 14:06 changhyuni

Did you check the docs? https://docs.fluentbit.io/manual/pipeline/outputs/cloudwatch seems to have some config options for log_group stuff - is that what you want or something else?

patrick-stephens avatar Jun 05 '24 15:06 patrick-stephens

@patrick-stephens thanks you for comment. I checked that I want this https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_TagLogGroup.html I guess fluentbit don't support cloudwatch TagLogGroup API

changhyuni avatar Jun 06 '24 04:06 changhyuni

@changhyuni what's the blocker on fluentbit supporting the TagLogGroup API?

InvisibleMan1306 avatar Jun 10 '24 14:06 InvisibleMan1306

@InvisibleMan1306 I want to tag the cloudwatch log group when Cloudwatch logGroup creation is set to AutoCreate.

changhyuni avatar Jun 13 '24 07:06 changhyuni

It should be possible to extend the CreateLogGroup call to include tags right, https://github.com/fluent/fluent-bit/blob/master/plugins/out_cloudwatch_logs/cloudwatch_api.c#L1297-L1329, https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_CreateLogGroup.html. That code would probably need to be changed a little to use JSON encoder instead of constructing a raw string since the logic would be a bit complicated.

InvisibleMan1306 avatar Jun 13 '24 12:06 InvisibleMan1306

@InvisibleMan1306 thanks you i will be trying that.

changhyuni avatar Jun 20 '24 11:06 changhyuni

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.

github-actions[bot] avatar Sep 19 '24 02:09 github-actions[bot]