Vaan1310

Results 41 comments of Vaan1310

> i wonder whats wrong with my codestyle Don't use wildcard(*) imports. Don't use functional methods like `.stream()` or `.foreach( x -> ...)`, just use a normal for loop. Saving...

> before i review this i would really like some benchmarks for this. Anything cargo may slow down the server massively Now it uses `SlimefunUtils#isItemSimilar` so the benchmark is the...

> We previously denied a PR like this since it’s in one of the addons already I think Just because an addon adds it it isn't a good reason to...

Could not find any addon that added a similar feauture, I have looked for quite a while

> this would break backward compatibility, add version check i completely forgot about that, on it

Applied to everything beside test enviroment for now

Maybe it is better if I move the StackResolver to the `compatibility` package, didn't know such a package exists already, should i call it `VersionedItemStack`?

Running with a local fork of MockBukkit

what are the advantages of using a delegate in this case?

For now I implemented a Patch and plan to implement similar ones in [this](https://github.com/Intybyte/MovecraftPackets/) repository, it would be good if there was a way to fix this without protcol lib,...