Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

fix AContainer can't find recipes with similar items

Open JWJUN233233 opened this issue 10 months ago • 10 comments

Description

#4166

Proposed changes

Related Issues (if applicable)

#4166

Checklist

  • [ ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [x] I did my best to add documentation to any public classes or methods I added.
  • [x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

JWJUN233233 avatar Apr 27 '24 07:04 JWJUN233233

Your Pull Request was automatically labelled as: "✨ Fix" Thank you for contributing to this project! ❤️

github-actions[bot] avatar Apr 27 '24 07:04 github-actions[bot]

Can you update the PR to be inline with the code style guidelines

JustAHuman-xD avatar Apr 27 '24 07:04 JustAHuman-xD

i wonder whats wrong with my codestyle

JWJUN233233 avatar Apr 27 '24 07:04 JWJUN233233

i wonder whats wrong with my codestyle

Don't use wildcard(*) imports. Don't use functional methods like .stream() or .foreach( x -> ...), just use a normal for loop. Saving x and y Inputs in a variable would help with readibility.

Intybyte avatar May 04 '24 07:05 Intybyte

Variables need to be camel_Case

J3fftw1 avatar May 04 '24 07:05 J3fftw1

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 505b4442

https://preview-builds.walshy.dev/download/Slimefun/4177/505b4442

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar May 04 '24 08:05 github-actions[bot]

Thanks for the first PR we really appreciate it.

J3fftw1 avatar May 04 '24 09:05 J3fftw1

Don't we have an item utils already or something like it?

JustAHuman-xD avatar May 04 '24 12:05 JustAHuman-xD

Don't we have an item utils already or something like it?

It seems not

JWJUN233233 avatar May 04 '24 13:05 JWJUN233233

bump

lijinhong11 avatar May 09 '24 10:05 lijinhong11