Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

new ItemStack => ItemStack.of

Open Intybyte opened this issue 1 year ago โ€ข 5 comments

Description

Use ItemStack.of instead of new ItemStack

Checklist

  • [ ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [ ] I followed the existing code standards and didn't mess up the formatting.
  • [ ] I did my best to add documentation to any public classes or methods I added.
  • [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

Intybyte avatar Sep 25 '24 18:09 Intybyte

Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. โค๏ธ

Branch naming convention Label
feature/** ๐ŸŽˆ Feature
fix/** โœจ Fix
chore/** ๐Ÿงน Chores
api/** ๐Ÿ”ง API
performance/** ๐Ÿ’ก Performance Optimization
compatibility/** ๐Ÿค Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! ๐Ÿ‘€

github-actions[bot] avatar Sep 25 '24 18:09 github-actions[bot]

this would break backward compatibility, add version check

i completely forgot about that, on it

Intybyte avatar Sep 25 '24 18:09 Intybyte

Applied to everything beside test enviroment for now

Intybyte avatar Sep 25 '24 20:09 Intybyte

Maybe it is better if I move the StackResolver to the compatibility package, didn't know such a package exists already, should i call it VersionedItemStack?

Intybyte avatar Sep 26 '24 10:09 Intybyte

Running with a local fork of MockBukkit

Intybyte avatar Sep 30 '24 19:09 Intybyte