Alexey Gordeev

Results 16 comments of Alexey Gordeev
trafficstars

The issue is fixed in master and it's hard to rip off the fix from it as it depends on other code changes. More, it seems to be over-complicated and...

> Thanks a lot for your contribution. @InnerLife0 > > Have not looked into it (will do it soon, recently I am just too busy). I see we change some...

Hi, guys. Sorry for late reply. It was difficult to force myself and to put my thoughts together. The patch doesn't contain any fix for `Dynamic Bitmap Heap Scan` as...

Thanks for review. For some reason I can't answer to some questions directly in their threads. More, I've figured out, some of my answers to such questions were no applied...

@yaowangm Thanks for review. I've resolved all conflicts and squashed last commits. I left two commits, because we think they shouldn't be mixed. UPD. [Here](https://github.com/greenplum-db/gpdb/pull/13481) is the same for 6X.

> 2. Run the tests like this on both GPDB6 and GPDB7 version and let me know the result: > > ``` > cd src/test/regress > make installcheck > cd...

> No, it's just part of the process to make ensure the code is safe. I have not run on my CI. I mean you already have automatically started CI...

> The automatically started CI covers just a small portion of pipeline. Usually we ask for a full dev pipeline which is run manually. Sorry, but this is something new...

> @InnerLife0 Hi~ Before I start to review this PR, I run a simple isolation2 test, and find there has many failed tests, doesn't look like a flaky case (means...

Should be fixed. And yes, it was flaky. The error was around the one new assertion from addressed PR comments. A lot of time has passed and I forgot why...