IanSims

Results 52 comments of IanSims

Hi @fredwes, Thanks for this PR! Just wondering if this PR also allows for keys to be stored in Windows Certificate Store?

@fredwes this branch is also a PR for your repo as well. If you decide to update your master branch on your repo, feel free to close this PR!

Hi @arthurschreiber, when you have the time, can you please review this PR? Thanks!

Thanks for pointing this out! We were actually looking into migrating to [@azure/identity](https://www.npmjs.com/package/@azure/identity) in replace of [@azure/ms-rest-nodeauth ](https://www.npmjs.com/package/@azure/ms-rest-nodeauth), which fortunately uses the new [@azure/msal-node](https://www.npmjs.com/package/@azure/identity) dependency.

@arthurschreiber eslint test is failing because of previous commit messages not following commitlint convention. Not sure how to fix. But overall this PR has been updated 😄

@tidhar-ziv Thanks for raising this issue, we'll see if we can create a fix!

Thanks for raising this issue, I'll take a closer look at it soon!

Hi @brsanthu, are you able to reproduce the error using tedious directly?

Do you have a repro case we can see? This might be due to connection.close() happening in an async manner. You can try to capture the [connection.on('end') ](https://tediousjs.github.io/tedious/api-connection.html#event_end)event before proceding...

Hi @charutiwari04, thanks for raising this issue. I've clarified that the `config.options.textsize` is set by type `string` in[ the documentation ](https://tediousjs.github.io/tedious/api-connection.html).