fix: remove retries for instance-lookup

[Suraiya-Hameed]

Removed option.retries from instance-lookup.js, this option does not exist and it is never passed from connection.js. Also, fixes #672

[arthurschreiber]

@Suraiya-Hameed I'm wondering why we even had this option in the first place. 🤔

[Suraiya-Hameed]

Same here. From issue #195, probably the were intending to remove retries but missed it!

[codecov[bot]]

Codecov Report

Merging #802 into master will decrease coverage by 0.92%. The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
- Coverage   80.77%   79.84%   -0.93%     
==========================================
  Files          86       86              
  Lines        4384     4376       -8     
  Branches      793      791       -2     
==========================================
- Hits         3541     3494      -47     
- Misses        584      626      +42     
+ Partials      259      256       -3     

Impacted Files	Coverage Δ
src/connection.ts	60.59% <0.00%> (-3.73%)	:arrow_down:
src/instance-lookup.ts	100.00% <100.00%> (+3.70%)	:arrow_up:
src/incoming-message-stream.ts	92.30% <0.00%> (-5.13%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2fb901a...35ff939. Read the comment docs.

[IanChokS]

@arthurschreiber eslint test is failing because of previous commit messages not following commitlint convention. Not sure how to fix. But overall this PR has been updated 😄

[arthurschreiber]

@IanChokS I double checked this. This removes the retries option, and also completely removes the retries. This might be problematic, as the server instance lookup is done via UDP, which is not reliable and can have packets silently dropped.

I think maybe we should remove the retries option, but also exposing a way to abort the lookup? Then we could just keep on retrying until we hit the connection timeout. @IanChokS @MichaelSun90 what do you think?