IMinchev comments

Results 12 comments of


                                            IMinchev

Change window to globalThis in Virtualizer.ts for SSR

I apologize for being pushy, but will there be any update on this? @kevinpschaaf

Change window to globalThis in Virtualizer.ts for SSR

> @IMinchev64 this looks good. We just need to format the file and add a changeset file (run `npm run changeset`). @justinfagnani Is it fine now?

Change window to globalThis in Virtualizer.ts for SSR

@justinfagnani I finished running the lint and format scripts as per the [guidelines ](https://github.com/lit/lit/blob/main/CONTRIBUTING.md#pull-requests) so now the formatting should be fine as well

Change window to globalThis in Virtualizer.ts for SSR

I'm currently looking into what went wrong with the formatting. @enesozturk

Change window to globalThis in Virtualizer.ts for SSR

@justinfagnani I hope the formatting is correct now. It's just for the Virtualizer.ts now so fingers crossed all is good.

Change window to globalThis in Virtualizer.ts for SSR

@justinfagnani Can you rerun the ci please?

[Elements] hGrid excel export does not export child grid data

This seems to also reproduce on latest master if on grid initialization the columns in a row island are disabled and later reenabled. Seems the columns array property is not...

fix(IgxGrid): Fix event args for rowAdded too. Update test.

Are the additional commits in the PR intentional?

Change window to globalThis in Virtualizer.ts for SSR

@hrmcdonald I applied the suggestion from the comment. Thanks for the recommendation!

Splitter Indigo theme is not applied correctly

Resolved by PR in the igniteui-theming-widget repository.