aframe-extras icon indicating copy to clipboard operation
aframe-extras copied to clipboard

Published 20 hours ago • verified publisher icon c-frame

Fix WebXR handedness search for gamepad-controls

Open zach-capalbo opened this issue 3 years ago • 2 comments

At least in the current version of the WebXR spec, handedness is a property of XRInputSource (xrController), rather than Gamepad.

This leads to an issue discussed on the WebXR Discord chat (https://discord.com/channels/758943204715659264/759166287901098024/856977980219981844) where the controls attach to the wrong hand, even when the correct hand shows up later.

zach-capalbo avatar Jun 24 '21 22:06 zach-capalbo

I have built dist with this change in my own fork and can confirm that it fixes the issue on Quest 2

Live example: https://glitch.com/edit/#!/enormous-fire-shop

Hypnosphi avatar Feb 19 '22 21:02 Hypnosphi

Could this PR be merged, please? Or let us know why not.

micrology avatar Apr 22 '22 16:04 micrology

This PR is merged in the community fork https://github.com/c-frame/aframe-extras/issues/5

vincentfretin avatar Nov 03 '22 11:11 vincentfretin

The changes are now also in this repo.

vincentfretin avatar Nov 04 '22 07:11 vincentfretin