HypeMC

Results 67 comments of HypeMC

> > requires [symfony/symfony#58240](https://github.com/symfony/symfony/pull/58240) > > why don't we implement `ResetInterface`? So we won't need Symfony 7.2 to benefit from this feature. @nikophil Hi, the reason is [your comment about...

> > depends on the execution order and a specific test being run first > > yeah... we're doing strange things to test behavior between tests in this library 😅...

@nikophil Funny thing, the test was kind of already there, it just didn't work when all tests were run cause it requires `TestTransport::$enableMessagesCollection` to be set to its initial value...

@nikophil The fix has been released by Symfony, however, I don't think it's possible to get the tests for 6.3 and 7.0 to pass since those versions are no longer...

> @HypeMC would you mind to rebase your PR? @nikophil Done

> What about directly deprecating this option, so that it needs to be set on 8.0? Or defaulting it to true in 8.0? I'm ok with whatever is decided.

I'm still planning on finishing this, just haven't found the time yet :(

> take a look at #8498 Yes, this would help with this PR, tnx

@wouterj Great, thanks for the heads up. I was planning on doing it in the following weeks, but I'll wait for you to finish then, before I continue.

@alamirault Actually, I've just been working on it, see #20777