symfony icon indicating copy to clipboard operation
symfony copied to clipboard
verified publisher icon symfony

[FrameworkBundle][PropertyInfo] Wire the `ConstructorExtractor` class

Open HypeMC opened this issue 2 years ago • 3 comments

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

A sort of followup to #30335.

The original PR removed the wiring to prevent creating a BC break, see https://github.com/symfony/symfony/pull/30128#issuecomment-462169119 & https://github.com/symfony/symfony/pull/30335#issuecomment-480799499.

This PR proposes adding a new framework.property_info.with_constructor_extractor configuration to allow optionally enabling the framework integration. The configuration defaults to false to prevent creating a BC break. Only when it's set to true will the ConstructorExtractor be registered in the container.

HypeMC avatar May 16 '23 00:05 HypeMC

What is the status of this PR ? It would be nice to see this in 7.1.

michaljusiega avatar Feb 22 '24 12:02 michaljusiega

What about directly deprecating this option, so that it needs to be set on 8.0? Or defaulting it to true in 8.0?

OskarStark avatar Oct 14 '24 10:10 OskarStark

What about directly deprecating this option, so that it needs to be set on 8.0? Or defaulting it to true in 8.0?

I'm ok with whatever is decided.

HypeMC avatar Oct 14 '24 15:10 HypeMC

Thank you @HypeMC.

fabpot avatar Jan 06 '25 17:01 fabpot