Oscar Hinton
Oscar Hinton
We need to figure out what margins to use. @danielleflinn something you can assist with perhaps?
None really. The jira ticket covers the different approaches and for our use case classes works just as well as angular directives. If I remember correctly the thinking was that...
One goal that hasn't been noted in this PR, is the potential use case for a domain model to have multiple views with different amount of data. I kept the...
Having an interface on Domain to determine which key is used to encrypt things seems reasonable, it could be argued it's part of the domain model. Something that came to...
@eliykat I understand and I didn't want to muddle this PR with any refactoring of `CryptoService`. I agree with the move to `KeyService` and have `EncryptService` depend on `KeyService`. But...
I've removed the `Cipher` changes from this again, and changed the target to a new feature branch. My thinking is that we'll review this to ratify the general patterns, get...
We can discuss it in the future PR, but I don't want to mix in any knowledge of views in the domain. Since domain is in the center and the...
Hmm this seems interesting. We are using the regular https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/input_event. As seen in https://github.com/bitwarden/web/blob/master/src/app/vault/groupings.component.html#L21. This seems more like a bug with either Angular or with the Oculus browser. Will need...
Hi @jief666, Does this always occur when switching account?
The first line of that error is not related to sending emails but rather push notifications.