Oscar Hinton
Oscar Hinton
@claude can you review the pr.
@harr1424 This PR seems to do several things, what parts of this actually resolves the stated issue, i.e. popout crashes.
Should the settings page be unowned? I'm not quite sure why it's owned by tools.
Hi @jbillingredhat, We use the default installation template for electron-builder, and we've recently upgraded electron builder to the latest version. However it seems they still `chmod` the chrome-sandbox. https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/templates/linux/after-install.tpl#L14. A...
While it is possible to diverge from the default electron-builder settings to do so would require us to investigate the issue further and make certain there are no degraded experiences...
Please run prettier it should remove most teams from the review list due to the files being wrongly re-formatted ...
Some behavioral things noted while testing: - Navigating to any filter should navigate you to the vault page. - It should be possible to select item types and folders while...
- The web builds are failing. - Is there a way to reset "My vault" and "org" filters?
FYI you have some type errors in the test files, you can run `npm run test:types` from the root of the repository to reproduce these locally.
FYI there is a `theme.css` in `libs/components/src/` that defines fonts which might be nice to use? And is probably a good place to share variables with the regular design system...