Oscar Hinton
Oscar Hinton
As we discussed this seems like a nice improvement. We'll want to rework this so that buttons can have their own handlers if they aren't the main submit button. And...
We could certainly hide the state depending on values. We probably also want a way to re-trigger the captcha right?
I took a quick look but it's typically difficult to review migrations scripts directly without the `Sql/dbo` files.
I'm a bit split on the StringBuilder stuff. I suspect it won't improve performance since StringBuilder has more overhead than just using a string for limited number of concatenations. However...
I generally try and use string builders in loops. Otherwise it feels like micro-optimizations :).
@joseph-flinn Do you have any thoughts as to why we don't remove the `setup` image? At a quick glance it seems the other containers are removed in the restart command,...
We've improved the version detection in this release, and it should no longer announce a newer version before it is released. https://github.com/bitwarden/server/pull/2006
Thanks for letting us know @adam-olson. This will be resolved in the next release.
@joseph-flinn Do you know if this has any potential negative impact for non SELinux users?
I'm happy with this change as well! Probably easier to re-run the changes on the latest master though.