Kyle Benesch comments

Results 315 comments of


                                            Kyle Benesch

allow copying files into an already existing directory

You're right. It seems it'd delete the folders contents and start over if this check didn't stop it. I'm wondering if that's actually desirable or what the edge cases are....

delocate makes links that do not match the filenames of the libraries

I can you check this again with the latest version `0.9.1`? The versions of delocate before `0.9.0` did not handle recursive libraries correctly. I expect that the latest version of...

Code cleanup suggestions.

My PR #93 was flawed from the start since I tried to refactor the entire code base all at once. I assume I could refactor everything again over multiple distinct...

Error fixing wheel: libfreetype.6.dylib already exists

I think is issue was fixed by PR #94. Could you try again with the latest version of delocate?

Error fixing wheel: libfreetype.6.dylib already exists

Duplicate of #53

remove wheeltools.py, import/require standalone wheeltools

So what is the status of this right now? It seems it hasn't been touched in years.

If wheel has no package directories, use lib_sdir as a suffix

Sorry for taking so long to respond. I've rebased the PR, updated a test, and documented the feature better. I think your implementation fits well with the existing API.

it would be nice if delocate-fuse would rename its output

Closed by PR #215

--require-archs shall check all mach-O files in the wheel

I'd consider it a bug. The problem is how `delocate.delocating.check_archs` takes the `tree_libs` variable, but that variable only tracks dependencies which will be copied and does not consider that any...

Consider using macholib instead of native otool and install_name_tool

Macholib seems to lack `@rpath` support for library lookups. https://github.com/ronaldoussoren/macholib/issues/2 There also needs to be a replacement for the codesign utility if the goal is to make delocate portable.