delocate icon indicating copy to clipboard operation
delocate copied to clipboard

it would be nice if delocate-fuse would rename its output

Open glyph opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe. delocate-fuse creates a universal2 wheel (which is amazing) but gives it the wrong tag

Describe the solution you'd like Do not rewrite the input in place, instead, put a wheel next to it with a modified tag name.

Describe alternatives you've considered It is not clear to me what other behavior would be correct :)

Additional context I'm not sure if this is a feature or a bug. It strikes me as incorrect behavior to write an x86_64 tagged wheel that has arm64 code in it, but I am filing it as an enhancement as I assume the existing behavior has some reason for existing.

glyph avatar Jan 26 '23 05:01 glyph

I'm afraid the reason it hasn't changed is because - it started that way. Would you be interested in changing it to give the correct tag instead, with a --retag optional flag to trigger that behavior (for back-compatibility)?

matthew-brett avatar Jan 26 '23 08:01 matthew-brett

@matthew-brett I'd think you'd want renaming to be the default. When you create a universal2 wheel, it's until it's properly named, it is useless at as best and harmful at worst because it no longer reflects the contents of the wheel correctly. If someone wants the existing behavior, they should opt in, not the other way. Even if this is a breaking chance for some scripts.

henryborchers avatar Oct 30 '23 19:10 henryborchers

Is your feature request related to a problem? Please describe. delocate-fuse creates a universal2 wheel (which is amazing) but gives it the wrong tag

Describe the solution you'd like Do not rewrite the input in place, instead, put a wheel next to it with a modified tag name.

Describe alternatives you've considered It is not clear to me what other behavior would be correct :)

Additional context I'm not sure if this is a feature or a bug.

Doondondon avatar Nov 04 '23 09:11 Doondondon

Closed by PR #215

HexDecimal avatar Aug 29 '24 06:08 HexDecimal