Henrik Gombos

Results 7 comments of Henrik Gombos

Given the help from https://github.com/dracutdevs/dracut/pull/2530 I removed the changes related to shellcheck version changes and just kept the code changes regarding SC2319 . Thanks @pvalena for your help with the...

> FWIW, this line would also have to be removed: > > https://github.com/dracutdevs/dracut/blob/6af3fcfd7f699ec4bb3f1e9ac71b7a9ebb9804b3/test/Makefile#L4 Thanks @aafeijoo-suse for the review. Unfortunately, I do not understand what else needs to be removed as...

> Can you see if you can find a way not to install `mkinitcpio` (the default `initramfs` provider on arch) ? There is a possibly solution used in the `Debian`...

Start working on https://github.com/dracutdevs/dracut/issues/2433 . Pulling in https://github.com/dracutdevs/dracut/pull/2427 as this PR would help with https://github.com/dracutdevs/dracut/issues/2433 . Marking in draft for now as I will likely need help with this PR.

@bdrung Thanks for the review. I added more reasoning to the git commit message. > test: skip test 50,60 if ifcfg dracut module can not be installed > > Test...

> That information could go into the commit message as well, saying something like: Instead of disabling the test, they should be reimplement so that they do not require ifcfg...

> Do you plan to tweak more things in the `.gitignore` file? if so, please do it in this PR. I only wanted to make this one change. I do...