dracut icon indicating copy to clipboard operation
dracut copied to clipboard

fix(test): running tests no longer requires to be root

Open Henrik66 opened this issue 2 years ago • 4 comments

After https://github.com/dracutdevs/dracut/commit/fd9cd02cb21f25d32fec4cd9889457ea6361f45e, tests no longer requires to be root. Being able to run VMs to run tests is required, but that should not imply root user.

Fixes https://github.com/dracutdevs/dracut/issues/1147 and https://bugs.gentoo.org/298014

Henrik66 avatar Jul 14 '23 02:07 Henrik66

FWIW, this line would also have to be removed:

https://github.com/dracutdevs/dracut/blob/6af3fcfd7f699ec4bb3f1e9ac71b7a9ebb9804b3/test/Makefile#L4

Thanks @aafeijoo-suse for the review. Unfortunately, I do not understand what else needs to be removed as the line 4 of test/Makefile is already removed in this PR - see https://github.com/dracutdevs/dracut/pull/2429/files#diff-740cb5a1689091cb894445e46683c255e39689ccba1c6c63d8a8841c8df8817dL4 . Can you help me understand please ! Thanks !

Henrik66 avatar Jul 17 '23 20:07 Henrik66

FWIW, this line would also have to be removed: https://github.com/dracutdevs/dracut/blob/6af3fcfd7f699ec4bb3f1e9ac71b7a9ebb9804b3/test/Makefile#L4

Thanks @aafeijoo-suse for the review. Unfortunately, I do not understand what else needs to be removed as the line 4 of test/Makefile is already removed in this PR - see https://github.com/dracutdevs/dracut/pull/2429/files#diff-740cb5a1689091cb894445e46683c255e39689ccba1c6c63d8a8841c8df8817dL4 . Can you help me understand please ! Thanks !

Sorry, I missed that change somehow... it's all good

aafeijoo-suse avatar Jul 18 '23 06:07 aafeijoo-suse

CC @bdrung for his possible feedback

LaszloGombos avatar Aug 15 '23 23:08 LaszloGombos

+1 from my side. I tested the patch from this PR plus https://github.com/dracutdevs/dracut/pull/2484 successfully for the tests 01 02 03 04 on Debian and Ubuntu.

One caveat: The kernel on Ubuntu is only readable by root. So either make it readable or run as root. See https://launchpad.net/bugs/759725

bdrung avatar Aug 15 '23 23:08 bdrung