Haris Spahija

Results 29 comments of Haris Spahija

I think there are ways to use the current proptypes in combination with type definitions. Perhaps you could find a tool that converts them?

Can labels be added for this issue? I think its a fairly easy starting issue.

Hey, this issue doesn't seem to get a lot of traction. When it comes to components every single component that has text would need to get an extra prop for...

Did you guys ever make any progress on this issue @nnnnat @aldeed ?

@nnnnat could you check if the current PR's are viable to be implemented?

@CristianCucunuba Id say check out this issue: https://github.com/reactioncommerce/example-storefront/issues/524 You could fork the master branch and create an example using the new label props to show translations. I think its best...

I noticed that some components are using other components from the component library. Components such as MiniCart make it so labels cannot be passed to MiniCartSummary without either overriding componentContext...

I tried setting an override in component context, but I couldnt get the syntax to work without sideffects. Could you elaborate how to do this with an example?

This should be easy to fix, could you elaborate if any other components have the same issue?