reaction-component-library icon indicating copy to clipboard operation
reaction-component-library copied to clipboard

Published 20 hours ago • verified publisher icon reactioncommerce

TypeScript type definitions

Open Kiailandi opened this issue 4 years ago • 5 comments

Hello,

I might be wrong, but I wasn't able to find any TS definition for @reactioncommerce/components.

Is this a problem on my side or are there no TS definitions to be found?

I really like the Reaction Commerce component library, but having to manually declare a definition for each component is really slowing down my development process.

In case no definition is available would you be interested in adding them? I could probably try to contribute.

Thanks.

Kiailandi avatar Mar 06 '20 14:03 Kiailandi

@mikemurray @willopez Thoughts on this?

rymorgan avatar Mar 06 '20 17:03 rymorgan

There aren't any yet but we would welcome any PRs to add some

aldeed avatar Mar 11 '20 01:03 aldeed

I think there are ways to use the current proptypes in combination with type definitions. Perhaps you could find a tool that converts them?

HarisSpahija avatar Mar 11 '20 08:03 HarisSpahija

I will try to find something and report back.

Kiailandi avatar Mar 16 '20 11:03 Kiailandi

See also: https://github.com/reactioncommerce/example-storefront/issues/709

ghost avatar Mar 10 '21 07:03 ghost