Hans Olsson

Results 628 comments of Hans Olsson

> The point was to do away with the easy parts, so that only the parts needing more discussion would need to wait. By this split, it also gets easier...

> Yes, and this style was introduced long time ago (buy now). It was probably simply too much work or risk of introducing merge conflicts with other ongoing changes for...

Regarding how to write `choicesAllMatching` I prefer the simple `Boolean choicesAllMatching`. Partially because it is simple, and partially because there are various enhancements ideas of supporting non-literal values for such...

> > Regarding how to write `choicesAllMatching` I prefer the simple `Boolean choicesAllMatching`. Partially because it is simple, and partially because there are various enhancements ideas of supporting non-literal values...

> @sjoelund have you changed anything?

Looking more I don't think that using textvisiblespace is significantly better than just plain space. If we want to make it clearer we could use Modelica for something like `\lstineline!"$packageName$"+"...

> > suggest that showStartAttribute is redefined to only apply to parameters. > > For me, `showStartAttribute=true` only makes sense for variables (those that become ODE states or iteration variables)...

> While I can see that it would be possible to use the same "dialog" for applying that sort of structural modification, it is certainly not what I would consider...

> > Basically if we want to argue that we have made the wrong choice for the default then we should see that there are lots of cases where default...

To me this issue can now be closed.