forge icon indicating copy to clipboard operation
forge copied to clipboard

Keyword Offering update like Defiler as Additional Cost Increase + Reduction

Open Hanmac opened this issue 3 years ago • 4 comments

the Keyword Offering works similar like the Defiler Ability

when updating the Defiler Ability for Card Text Changes #1828 we might use the same mechanic for Offering so we don't need extra variables anymore.

if possible we might look into Emerge for this too

Hanmac avatar Nov 21 '22 12:11 Hanmac

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.

github-actions[bot] avatar May 13 '23 09:05 github-actions[bot]

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.

github-actions[bot] avatar Jun 13 '23 09:06 github-actions[bot]

I think keeping AI support will be the tricky part.

tool4ever avatar Jun 04 '24 12:06 tool4ever

I think keeping AI support will be the tricky part.

For Offering/Emerge, i think once i get the Functionality going, the AI part shouldn't be that much of a problem

Hanmac avatar Jun 04 '24 13:06 Hanmac

@tool4ever check out this Issue while touching Offering

Hanmac avatar Jul 24 '25 13:07 Hanmac

@tool4ever you recently touched Offering,

https://github.com/Card-Forge/forge/blob/2d20ce07e3ec70b615e9b3ea039ba888c68d3188/forge-gui/src/main/java/forge/player/HumanPlay.java#L520-L540 shouldn't HumanPlay call this Method in CostPayment? https://github.com/Card-Forge/forge/blob/2d20ce07e3ec70b615e9b3ea039ba888c68d3188/forge-game/src/main/java/forge/game/cost/CostPayment.java#L336-L364

Also, isn't this part redundant? https://github.com/Card-Forge/forge/blob/2d20ce07e3ec70b615e9b3ea039ba888c68d3188/forge-gui/src/main/java/forge/player/HumanPlay.java#L606-L615

i might need to clean this up if i want to do Convoke/Improvise later🤔

Hanmac avatar Aug 20 '25 14:08 Hanmac

I think it's been tricky to merge the logic because of AI and human differences there

tool4ever avatar Aug 20 '25 20:08 tool4ever

i need to experiment with the duplicated code i think i can clean this up

Hanmac avatar Aug 21 '25 07:08 Hanmac