Guy Sleigh comments

Results 9 comments of


                                            Guy Sleigh

[DNM] MP-9 Integrate Glean.js MDN

---------------------- ## DATA REVIEW REQUEST ---------------------- 1. What questions will you answer with this data? - \# Unique visitors to MDN - What are our top pages? - What does...

[DNM] MP-9 Integrate Glean.js MDN

>Before I can continue with your data-review, I would need to know the answer for what sensitive information could be collected by this, especially the path and referrer metrics. With...

[DNM] MP-9 Integrate Glean.js MDN

@travis79 Thanks for the great feedback. I've posted a question to one of your comments and will be updating the fields as and when I can get a handle on...

[DNM] MP-9 Integrate Glean.js MDN

Hi @travis79 Thanks for the intial review. Sorry for the delayed response I was off on PTO. We have decided to drop the page_event for now and just go with...

fix(plus): add breadcrumbs for Collections/Notifications/Settings

1 change then LGTM. Thanks for picking that up 👍

fix(plus): add breadcrumbs for Collections/Notifications/Settings

Coolio. Thanks! :)

No stats being printed to logs

Hello, did you subscribe the consumer to a topic first? Try that and then call poll().

Config values can contain null characters resulting to panic

@davidblewett Would it be possible to get one of these solutions merged? What should be the process here?

how to use Dockerfile to build image of rust-kafka

Here's an example dockerfile I use with [cargo-chef](https://github.com/LukeMathWalker/cargo-chef) for faster builds . just place it in the root of your codebase in `Dockerfile` . replace `your_binary` with whatever your built...