yari icon indicating copy to clipboard operation
yari copied to clipboard

fix(plus): add breadcrumbs for Collections/Notifications/Settings

Open caugner opened this issue 3 years ago • 1 comments

Summary

Adds breadcrumbs for Collections/Notifications/Settings in MDN Plus.

Problem

MDN Plus did not have breadcrumbs (except for the "Documentation" section).

Solution

Make it easy to add breadcrumbs to non-Doc pages.


Screenshots

Before

image

After

image

How did you test this change?

Checked out these pages locally:

  • http://localhost:3000/en-US/plus/collections
  • http://localhost:3000/en-US/plus/notifications
  • http://localhost:3000/en-US/plus/settings

caugner avatar Sep 30 '22 04:09 caugner

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Oct 06 '22 15:10 github-actions[bot]

1 change then LGTM. Thanks for picking that up 👍

Guyzeroth avatar Oct 18 '22 13:10 Guyzeroth

Coolio. Thanks! :)

Guyzeroth avatar Oct 19 '22 14:10 Guyzeroth