Gustavo Reis Bauer

Results 27 comments of Gustavo Reis Bauer

@timreichen true, it would make a lot more sense, I'll take a look at their implementation then :)

For sure @MarcosSpessatto, just found out there were comments in JIRA. I will add the warning

is it possible to add some tests validating that the login with third party apps is working even without the 'manage-oauth-apps' permission?

> > is it possible to add some tests validating that the login with third party apps is working even without the 'manage-oauth-apps' permission? > > It would probably be...

Just pushed the new permission to the branch, please update the tests :P

@te-online, I kind of forgot about it. I added here since I needed this function inside the library, but I hacked my way into it a few months ago Will...

Hey @thepiyush-303 thanks for your contribution :) There is no need to ping anyone, your PR will be reviewed as soon as possible. But taking a closer look at it,...

I am not a frontend dev, but I don't think there is a need to store the value the same way the user put in, for example: the user inserts...

That is what I mean, the backend should not support multiple settings because we should not have multiple settings. I am pretty sure no one will approve that, the settings...

I mean, if you have the time I think it would be a cool addition to do it in the client