Gustavo Reis Bauer
Gustavo Reis Bauer
What I mean by that is, we have user preferences that we store in the database, I don't think those inputs should be mapped to actual values in the database,...
Hey @thepiyush-303 did you update the PR? I couldn't see your changes :) also, thanks for your dedication
It looks like it might be some JIRA integration failing... does it pass locally?
Please add a changeset stating the changes you've made, besides that, looking good to me :)
hey @noobbbbb it is pretty good, if you are curious about how changeset should be written you can take a look at our manual: https://developer.rocket.chat/v1/docs/development-workflow#adding-changeset-to-your-pull-request
Looks good to me :)
Hey, I agree with @debdutdeb we should have an API test for this as well
Hey @Curious-Goblin no need to keep merging develop into your branch, you're good. Let's run the CI to see, but looks good to me
Hey, we don't merge PR's with failing tests, please fix that, then I will look into QA-ing
The UI tests are not, but there is one API test that is: `should reject invalid bio values (e.g., null):`