Manan Gupta
Manan Gupta
The links to specific files and line numbers should also be generated, so that if the files change, the links still point to the correct line.
`vttablet_prscomplex` failure is unrelated to this PR.
Rest looks good to me, we would need to add summary changes for the same for 20.0.0. @deepthi Do you have any other change in mind?
I'll do the website docs update by EOD. Update - Here is the docs PR - https://github.com/vitessio/website/pull/1702
#14939 might not be the correct bug fix. We still merged it, cause its a good change regardless, but we'll keep the issue open until the follow up on https://github.com/vitessio/vitess/pull/14939#pullrequestreview-1872819017...
I've been looking at the code to follow up on the comment from @vmg https://github.com/vitessio/vitess/pull/14939#pullrequestreview-1872819017 and I believe I have found where we are breaking the contract for gRPC! Take...
I misunderstood the docs and as it turns out that https://github.com/vitessio/vitess/issues/14760#issuecomment-1945869133 isn't really an issue. I thought that when the doc said `but it is not safe to call SendMsg...
Something to address in this PR - https://github.com/vitessio/vitess/pull/14871#discussion_r1524045385
@maxenglander This is a very well-written RFC! I looked at the query-serving related code in the linked PR too, and that looks good to me too!
@VaibhavMalik4187 Could you address the changes requested in the PR.