Manan Gupta
Manan Gupta
@arthurschreiber Yes, you're right. Even during PRS, the primary tablet can send a serving health check when it is in the grace period. I have reworked the solution a little...
Yes, 100% correct.
Yes, I agree, Grpc is a good idea, and Derek has hit the nail on the head, the rest calls are because of orchestrator, and we never did the work...
Nothing specific that I can think off at the moment.
Yes, I don't mind replacing it with proto. I agree with not wanting to keep two structs in sync. Its hard and liable to be messed up sometime in the...
I took a look at the code in depth today. And yes there are some problems in the code. I'll describe both the grpc and mysqld problems separately. For the...
Hello @joekelley, just a couple of review comments are left to be addressed - https://github.com/vitessio/vitess/pull/16050#discussion_r1645885668, before we can merge this PR.
Thanks Arthur! I was able to reproduce the problem now!
@arthurschreiber Its complete from my side, just waiting for Deepthi to review it. It would be great if you can test it out though!
Perfect! Thank you!