vitess icon indicating copy to clipboard operation
vitess copied to clipboard

Remove deprecated vtctl commands

Open ajm188 opened this issue 1 year ago • 4 comments

Description

e9aab81093 - These commands were deprecated even before the vtctldclient migration, so they are doubly-safe to remove.

Related Issue(s)

Checklist

  • [ ] "Backport to:" labels have been added if this change should be back-ported to release branches
  • [ ] If this change is to be back-ported to previous releases, a justification is included in the PR description
  • [ ] Tests were added or are not required
  • [ ] Did the new or modified tests pass consistently locally and on CI?
  • [ ] Documentation was added or is not required

Deployment Notes

ajm188 avatar Feb 14 '24 13:02 ajm188

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

  • [ ] Ensure that the Pull Request has a descriptive title.
  • [ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • [ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • [ ] Apply the release notes (needs details) label if users need to know about this change.
  • [ ] New features should be documented.
  • [ ] There should be some code comments as to why things are implemented the way they are.
  • [ ] There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • [ ] Is this flag really necessary?
  • [ ] Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • [ ] Each item in Jobs should be named in order to mark it as required.
  • [ ] If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • [ ] Protobuf changes should be wire-compatible.
  • [ ] Changes to _vt tables and RPCs need to be backward compatible.
  • [ ] RPC changes should be compatible with vitess-operator
  • [ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • [ ] vtctl command output order should be stable and awk-able.

vitess-bot[bot] avatar Feb 14 '24 13:02 vitess-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.70%. Comparing base (696fe0e) to head (b52a0ea). Report is 310 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15228      +/-   ##
==========================================
- Coverage   67.41%   65.70%   -1.72%     
==========================================
  Files        1560     1562       +2     
  Lines      192752   193902    +1150     
==========================================
- Hits       129952   127397    -2555     
- Misses      62800    66505    +3705     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 14 '24 14:02 codecov[bot]

Something to address in this PR - https://github.com/vitessio/vitess/pull/14871#discussion_r1524045385

GuptaManan100 avatar Mar 14 '24 08:03 GuptaManan100

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

github-actions[bot] avatar Apr 14 '24 01:04 github-actions[bot]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

github-actions[bot] avatar May 16 '24 01:05 github-actions[bot]

closing this as i won't have time to work on it for a while, please free to pick up this branch though!

ajm188 avatar May 16 '24 10:05 ajm188