Grummel7

Results 41 comments of Grummel7

Things get a bit messed up now. I once suggested to remove ownership of buildings, but that has nothing to do with this issue. We have a problem that a...

Well, if you look at #3725, I've just added a tag with an underscore. The problem was that the tags were all named like the effect groups implementing them, except...

> ```python > policy_diversity_threshold = get_named_int("PLC_DIVERSITY_THRESHOLD") > ``` > > This is executed during the import, which might not work. > > Let's move this thing together first and later...

Of course writing the errors only to the log was not what I intended. But I missed the fact that error() only produces a chat message once the game has...

It came in with [this](https://github.com/freeorion/freeorion/commit/fdeac67c8db1d8a5cd91d1964dd6cfdd0f2e43ca) commit. Argh! These warnings have always been there, but so far they were just written to the AI-log, were nobody cared for them... @Cjkjvfnby: ```...

TurnsSinceLastConquered returns 0 when the planet was never conquered, so with the current implementation only conquered planets can support at all. You could also add a comment that, while there...

> I'm not sure where this is looking up the wrong type... It shouldn't be in ValueRef GameRule lookups, as those will automatically handle casting. The issue also is sometimes...

I just compiled various code bases and I can now say the issue has been caused by 8b1d7c3dd9ee9b58d160980613a1a6caa5162eea.

> probably related to [f5d5f28](https://github.com/freeorion/freeorion/commit/f5d5f28675cee9fe3b2780b197ac94404d06b03e) No, I can reproduce it when using 8b1d7c3dd9ee9b58d160980613a1a6caa5162eea "rework ValueTest::Eval to avoid repeated evaluations of valuerefs whe…" (which is older than f5d5f28675cee9fe3b2780b197ac94404d06b03e), but not with...

Indeed I cannot reproduce it with master anymore