Steven L

Testify had a release! 1.2.2 has this feature: https://github.com/stretchr/testify/blob/v1.2.2/mock/mock.go#L220-L239 I can probably make a pull request to upgrade and use it internally. Since this is exposed to callers via `Mock`...

tbh I'm planning on deleting these mocks entirely in a future version. mocks can be generated by users with the library of their choice, rather than being stuck with our...

Yeah, we've been having that issue with mockery and gomock internally too. Gomock at least has a "source" mode in the flags (as opposed to using reflection), which seems to...

but in the meantime! if you're interested, I think this could work. I want to pin versions though, and bake them into the makefile - it's not too hard. do...

eh, that took more fiddling than expected. https://github.com/Groxx/cadence-client/commit/ff949d2dab21386c7c38944446b1e6188b1472ef

Yeah, we were actually just discussing this lately too. Along with cron-"fired at" time. How is it built in temporal, and which times do you use? (task-scheduled, workflow-created, cron-timer-fired-database-time, etc?)...

Gonna close since #885 solves this, so it's no longer needed. Apologies on the delay! And thanks for the PR regardless, more are welcome and I'll try to check my...

Yea, applying this patch brings me from ~20% failure to zero after thousands of iterations: ```diff diff --git a/transport/grpc/transport.go b/transport/grpc/transport.go index 15d69460..2c7a2c32 100644 --- a/transport/grpc/transport.go +++ b/transport/grpc/transport.go @@ -39,6 +39,7...

Yeesh. That's kinda a disturbing site, lots of misleading ads. Don't suppose you could make a "release" of it here?

Yea - makes sense and looks safe to me. Is this user-controlled / just optional in general so nulls are obviously possible, or is there code somewhere that should be...