cadence-java-client icon indicating copy to clipboard operation
cadence-java-client copied to clipboard

Fix for null pointer exception in case header getFields is null

Open abhishekj720 opened this issue 1 year ago • 1 comments

What changed? Added a fix for the case when headers's getFields is null. Causing null pointer in the code.

Why? Bug fix

How did you test it? Need to add test for it. will discuss with the team, now adding this to fix bug and unblock customer.

Potential risks It should be a safe change, as it is returning empty map in case of empty getFields.

Release notes

Documentation Changes

abhishekj720 avatar May 02 '24 23:05 abhishekj720

Yea - makes sense and looks safe to me.

Is this user-controlled / just optional in general so nulls are obviously possible, or is there code somewhere that should be populating this? Now's a good time to go hunting if it's unknown, since this'll basically be hiding the flaw for who knows how long if it actually is a flaw.

(it does seem pretty likely that this is just optional / user controlled though)

Groxx avatar May 03 '24 01:05 Groxx