Steven L

Results 84 comments of Steven L

Hum. I wonder if I pushed the wrong branch or something. Will fix.

there's a decent chance this was filed for the errors I'm seeing. if so: we've been investigating in a lot more detail, our defers don't seem related.

Yeah, AFAICT the shutdown process just closes a channel and returns :| so there's no way to _wait_ for a clean shutdown. There are a few other shutdown leaks throughout...

Yeah, we could take this opportunity to rename. I think it's unavoidable that this is going to be a breaking change in some way - at the very least, go...

RPC is the one and only purpose of that generated code, yeah - it's very specific but I don't see it as inaccurate. Though it doesn't contain e.g. ready-for-use RPC...

> One way to keep things backward compatible for Go 1.15 users is to keep the `.gen` directory and optionally add build tags in front of each file to disable...

Personally I'd much prefer all of these to be internal. Generated code is a thing _we_ control, it doesn't control us - it's not hard to add a "rewrite import...

Sorry about the delays :| Got busy and then moved across the country, and kinda only now catching up again. I'll re-trigger the test runs, though I suspect tests will...

I've got a fix for one piece of the test failures currently, in #1175 (in the meantime, just `make copyright`), and I'm not sure if it was working before or...

Tests pass, I kinda have to figure out a way to make sure the output data still works though :| I'm not entirely sure how to do that off-hand. We...