Jérôme Tamarelle
Jérôme Tamarelle
This is a great performance optimization. I shared some references on https://github.com/twigphp/Twig/pull/3588. Regarding security: the hashed contents comes from an external input. An attacker could manipulate the query string so...
Oh exact. So at most the attacker could update a page without invalidate the cache. That seems safe.
> About the name of the new methods, what about `asInt` or `toInt`? Note that I would also suggest to rename _all_ methods, eg getBoolean, etc. I would not invent...
I agree that we can define a `RecordFactory`. Can you make a pull request ?
:+1: The iframe is a good idea. You can use a subdomain for the XSS issue.
If place for the temp dir is different from one system to an other, and that can't be detected automatically, what about a new config?
Should be fixed. https://github.com/cocur/slugify/pull/299
Here are some code that can help: https://github.com/bernardphp/bernard/tree/master/src/Driver
The naming `fieldName_ASC` is concise and consistant with [other parts ](https://github.com/opencrud/opencrud/blob/master/spec/2-relational/2-2-queries/2-2-3-filters.md#data-types)of OpenCRUD like filtering. There is an issue if we need to sort on several fields or on a field...
Input type be a union is not supported (yet). https://github.com/facebook/graphql/issues/488