Jérôme Tamarelle

Results 322 comments of Jérôme Tamarelle

*This error message is illegible; we need PHPStan to be more specific about what is incorrect in the array shape.* The configurations of the different files and environments are merged...

Since mongo 6.0.11-ent, the `$listSearchIndexes` stage returns nothing, while the previous versions threw a server error. This makes it more complicated to test and detect.

I found a more reliable way to detect when Search indexes are supported. And I made the test pass weither search indexes are supported or not: if there is an...

Caching raw database results isn't a pattern that we want to promote. A good MongoDB model design involves denormalizing documents to optimize usage. If you think a read cache is...

Thanks for your Pull Request! We love contributions. However, you should instead open your PR on the main repository: https://github.com/symfony/symfony This repository is what we call a "subtree split": a...

To continue @nicolas-grekas idea, we can attach a `#[Transition]` attribute to each enum case. This avoids repeating the `from` and lets you reuse the `name`. I find this makes the...

The configuration needs to be read during the compilation of the container. Use `$container->registerAttributeForAutoconfiguration(AsWorkflow::class, ...` to add a tag to every enum. (But I'm not sure enums can be discovered)....

You inherit from the constants of the parent `Workflow` class. Could it be a 2nd enum: one for states, one for transitions.

I should add tests, probably in `CodecCollectionFunctionalTest`.

What I understand is that calling `DocumentCodec::encode()` with something other than an object of the class it can encode is an error: the `DocumentCodec` implementation must throw an exception at...