Greg Domzalski comments

Results 43 comments of


                                            Greg Domzalski

Transmit EPK and use as public key during decrypt

@microsoft-github-policy-service agree company="Yubico"

Transmit EPK and use as public key during decrypt

Yup. Fair enough. I'll close that PR.

Transmit EPK and use as public key during decrypt

I've updated this PR to be based on the new 7.x code. I still need to do some regression testing on my side. But it would be really nice if...

Transmit EPK and use as public key during decrypt

@brentschmaltz Thanks for the feedback. That seems like a reasonable approach. What would you like the default behavior to be? Based on the documentation and assuming an opt-in to the...

Transmit EPK and use as public key during decrypt

Alrighty. Let me know if that aligns with what you were thinking. The diff definitely looks a lot cleaner - basically just adds at this point. I introduced a centralized...

Transmit EPK and use as public key during decrypt

Hey @brentschmaltz - just following up here.

[Bug] Unix systems (such as macOS and Linux) aren't building NET6.0 TFM

I repro'd it with .NET6 and .NET7 SDKs. I have not tried any of the 8 previews, but I suspect the same issue will be present. I'd be happy to...

Wrong decryption key for ECDH with keywrap

I'm also running into this issue and agree with @max4t In ECDH - the TokenDecryptionKey should be your private key. The public key needs to resolve to EPK. There are...

Wrong decryption key for ECDH with keywrap

It would also really be nice if on the flip side, if `KeyExchangePublicKey` is set on the `EncryptingCredentials` that `CreateToken` would automatically add `epk` to the header. It seems that...

Document required workflow permissions (README regression)

That would be fantastic. Thank you for the consideration!