azure-activedirectory-identitymodel-extensions-for-dotnet icon indicating copy to clipboard operation
azure-activedirectory-identitymodel-extensions-for-dotnet copied to clipboard

[Bug] Unix systems (such as macOS and Linux) aren't building NET6.0 TFM

Open GregDomzalski opened this issue 1 year ago • 2 comments

Which version of Microsoft.IdentityModel are you using? Note that to get help, you need to run the latest version. Latest dev / 6.31.0

Where is the issue?

  • [ ] M.IM.JsonWebTokens
  • [ ] M.IM.KeyVaultExtensions
  • [ ] M.IM.Logging
  • [ ] M.IM.ManagedKeyVaultSecurityKey
  • [ ] M.IM.Protocols
  • [ ] M.IM.Protocols.OpenIdConnect
  • [ ] M.IM.Protocols.SignedHttpRequest
  • [ ] M.IM.Protocols.WsFederation
  • [ ] M.IM.TestExtensions
  • [ ] M.IM.Tokens
  • [ ] M.IM.Tokens.Saml
  • [ ] M.IM.Validators
  • [ ] M.IM.Xml
  • [ ] S.IM.Tokens.Jwt
  • [x] Other (please describe)

Project build system: build/targets.props

Is this a new or an existing app? N/A

Repro

On macOS after cloning the repo:

./build.sh

Expected behavior Both netstandard2.0 and net6.0 TFMs are present in the generated NuGet packages.

Actual behavior Only netstandard2.0 is present. net6.0 is missing.

Possible solution Add net6.0 TFM to SrcStandardTargets in targets.props and TestOnlyCoreTargets in targetsText.props

Additional context / logs / screenshots / links to code I'm getting ready to submit additional bug reports and fix PRs that have to do with using ECDH + JWE. ECDH is not available in netstandard2.0. Since I develop on a mac, I must develop against the net6.0 and not the netfx TFMs.

GregDomzalski avatar Jun 22 '23 14:06 GregDomzalski

@GregDomzalski does it repro on .NET7 or .NET8-preview?

jennyf19 avatar Jul 09 '23 20:07 jennyf19

I repro'd it with .NET6 and .NET7 SDKs. I have not tried any of the 8 previews, but I suspect the same issue will be present. I'd be happy to try that anyways - just in case - if you'd like.

GregDomzalski avatar Jul 10 '23 17:07 GregDomzalski