Goober5000
Goober5000
> @Goober5000 @wookieejedi I'm confused on how this PR meshes with existing priority code for form-on-wing in `ai_add_goal_sub_player()` (aigoals.cpp:781-783) > > ```c++ > // Goober5000 - same with form-on-wing, since...
I haven't run any. EDIT: @EatThePath feel like doing some profiling tests?
I haven't tested for performance regressions but I *have* tested this in mission. I have no objection to performance testing but this is a pretty straightforward reduction in the number...
There are several goals here, in no particular order: 1. Address the Coverity issues 2. Improve performance to the extent possible in these functions 3. Apply polishing where appropriate It's...
> Thank you for adding the comment; now, where are your performance tests? @BMagnu ran a profiling run a few posts up which should cover that.
I'm happy to take him at his word, but based on your comment I've asked him to upload his data. But he's busy for the short term so it may...
This is theoretically possible, but may require a lot of work. The AI code is pretty complex, and even simple upgrades (such as to ai-stay-near-ship) can require changing many bits...
I don't suppose you have a copy of the mission that, when saved, produces this error? This is the sort of thing that's difficult to track down without a test...
It reminds me of the corruption that motivated the #5517 fix, but this isn't using the mission importer.
Hmm. It's entirely possible that updates were made to one part of the UI but not another part. There have been many updates over the years, and it's not uncommon...